[core] make ProcessFD, [Client,Server]Connection non copyable. #41106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
rynewang
changed the title
rkooo567
approved these changes
Nov 16, 2023
| @@ -299,32 +280,19 @@ ProcessFD &ProcessFD::operator=(ProcessFD &&other) { | |||
| return *this; | |||
| } | |||
|
|
|||
| intptr_t ProcessFD::CloneFD() const { | |||
There was a problem hiding this comment.
it is not used now btw? (I assume yes given deleting copy constructor just succeeds?)
There was a problem hiding this comment.
it's not used anywhere
rkooo567
reviewed
Nov 16, 2023
|
|
||
| void ProcessFD::CloseFD() { fd_ = -1; } | ||
| fd_ = -1; |
There was a problem hiding this comment.
hmm interseting... this seems actually never used (existing closeFd)
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Nov 29, 2023
…roject#41106) These classes carry system resources (FDs) and are not meant to be copied (and dup'd) so to avoid accidental copy we delete the copy constructors. also removed a dynamic_pointer_cast since it's an upcast so static suffices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These classes carry system resources (FDs) and are not meant to be copied (and
dup'd) so to avoid accidental copy we delete the copy constructors.also removed a dynamic_pointer_cast since it's an upcast so
staticsuffices.